search

sanjaynagi / AmpSeeker

A snakemake workflow for amplicon sequencing
https://sanjaynagi.github.io/AmpSeeker/
0 stars 3 forks source link

Bcl Convert Rule #19

Closed ChabbyTMD closed 1 year ago

ChabbyTMD commented 1 year ago

New rule to convert illumina output data to fastq files needed for workflow execution.

Will resolve #15.

sanjaynagi commented 1 year ago

Thats awesome, thanks @ChabbyTMD !! Have made a few tiny comments just to remove a few lines we no longer need.

It should be possible to commit some of them directly within the GitHub PR from my suggestions, but sometimes it's easier to go back to the IDE and make the changes. Up to you :)

sanjaynagi commented 1 year ago

Cool, Ive just removed the commented out lines. Will merge once CI is complete.

sanjaynagi commented 1 year ago

I've also added the temp() flag to the resources/reads directory, meaning that once files are renamed and copied into results/reads, the resources/reads/ folder will be deleted.

sanjaynagi commented 1 year ago

Merging, thanks @ChabbyTMD !