search

sanjeevyadavIT / magento_react_native

🛒 MageCart: E-commerce app for Magento 2.x written in React Native
GNU General Public License v3.0
281 stars 124 forks source link

Out of Stock Product throws exception when selection options #50

Open imrankhanjoya opened 5 years ago

imrankhanjoya commented 5 years ago

Describe the bug App crash while selecting size on a configurable product which is out of stock. reason: quantity value from server is not handled correctly in code

Expected behavior

  1. In case of configurable product, particular option which is out of stock should be disabled from selection
  2. In case of simple product, add to cart button should be disabled and message should be displayed out of stock on the screen.

Current Behavior App crash

Screen Shot 2019-09-22 at 12 36 00 PM
sanjeevyadavIT commented 5 years ago

Please give more context?

  1. Are you suing default store url or your own custom magento url?
  2. If you are using default store url, could you point out the which product you are opening?
imrankhanjoya commented 5 years ago

http://fiji.jaipurshine.com/summer-women-s-striped-dress-short-sleeve-off-shoulder-slim-sexy-long-dress-for-women.html This happens when product is out of stock and also don't see quantity option.

Thanks

sanjeevyadavIT commented 5 years ago

thanks for pointing that out, I haven't implemented this out of stock check in the code, currently the app is very basic and need to be refined at so many levels. If you are interested in contributing I will be happy to help you out.

sanjeevyadavIT commented 5 years ago

@all-contributors please add imrankhanjoya for bug

allcontributors[bot] commented 5 years ago

@alexakasanjeev

I've put up a pull request to add @imrankhanjoya! :tada: