search

sanjeevyadavIT / magento_react_native

🛒 MageCart: E-commerce app for Magento 2.x written in React Native
GNU General Public License v3.0
282 stars 124 forks source link

[iOS] Configurable option UI not rendring properly . #67

Closed MehmoodArib closed 5 years ago

MehmoodArib commented 5 years ago

Configurable option UI not rendering properly Drop down menu where we choose size and color of the configurable product and on address page where we select country & region are not rendering properly in iOS.

Expected behavior Drop down should remain hidden, and should only open when clicked.

Current Behavior Drop-down is open by default in iOS, which makes it hard to use, and if two of those are present side by side, their UI is overlapping with each other, making it hard to select.

Steps to Reproduce

  1. Open the app.
  2. Select any configurable item like(t-shirt).

Screenshots

Product Detail Screen product

Address Screen at the time of checkout Simulator Screen Shot - iPhone 11 - 2019-10-22 at 13 42 49

Smartphone (please complete the following information):

sanjeevyadavIT commented 5 years ago

Solution

  1. install react-native-modal-selector follow doc
  2. Create a new component ModalSelect that will be a wrapper around react-native-modal-selecotor in components/molecule folder

    See https://github.com/troublediehard/magento-react-native/blob/master/src/components/common/ModalSelect.js

  3. Write stories for ModalSelect using storybook
  4. Use this custom ModalSelect component and use it everywehere
sanjeevyadavIT commented 5 years ago

@all-contributors please add MehmoodArib for bug

allcontributors[bot] commented 5 years ago

@alexakasanjeev

I've put up a pull request to add @MehmoodArib! :tada: