Here a few other comments as I am now closer to a random user after not having used the tool for a while.
The user shoud understand the tool by just looking at the GUI. So here are a few suggestions for renaming (after the -> the suggested renamed label)
For the dropdown, as mentioned earlier, rather use constant variable ex: CENTERING = "displayed centering option" and use the variable instead of the string in your code, so we can easily change the string without having to rename the if case everywhere.
Generic comment that can be applied to other plugins
Add a short decription of what the tool is doing at the top (1-2 sentences, no fancy HTML)
Input directory -> "Annotate images in directory :"
Output directory -> "Save processed images/masks to" (otherwise not clear what will be save in the output directory)
Save format -> "Save images in format" (I guess it's the processed ones)
I would put there the saving options for the mask too, to have a more homogeneous GUI with all saving settings in one place, and as said in teams the Save mask tick box and the dropdown for the format on the same line.
Save mask -> Save generated mask
Task : Here too not clear what "Rotation" and "centering" means if not familiar with the tool, so let's be ultra-explicit. Looks maybe overkill, and sure it increases the length of the macro-recorded command but who cares, that's what the recorder is for.
Rotation -> "Align object to desired orientation (below)" here the below refer to the orientation dropdown
Centering -> "Move object to image-center"
Centering + rotation -> "Center object and then align to orientation"
Enlarge -> "Enlarge_canvas (prevent image cropping)", this one shoud record as enlargecanvas (mind the )
Object polarity -> "Alignement with object pointing to" -> ["Any", "Top (for vertical) / Left (for horizontal)", "Bottom (for vertical) / Right (for horizontal) "]
Move this option just after orientation or even maybe next to it, since it anyway only makes sense when doing "Align to desired orientation".
Maybe you could actually have a header "Alignment settings" that would gather orientation, polarity and rotation center.
And some ------ to finish that section (both using the addMessage from the GenericDialog class).
Comments specific to the batch annotation
I would move the save mask option just after the output directory, at the top : this is the first outcome of this annotation tool, at least chronologically for the user, the first things he does.
Then have a header introducing the "Image transformation settings"
And finally at the bottom the dropdown for the image format for saving the image.
So it matches what happens in the tool, the image transformation and then the saving
Here a few other comments as I am now closer to a random user after not having used the tool for a while. The user shoud understand the tool by just looking at the GUI. So here are a few suggestions for renaming (after the -> the suggested renamed label) For the dropdown, as mentioned earlier, rather use constant variable ex: CENTERING = "displayed centering option" and use the variable instead of the string in your code, so we can easily change the string without having to rename the if case everywhere.
Generic comment that can be applied to other plugins
Add a short decription of what the tool is doing at the top (1-2 sentences, no fancy HTML)
Input directory -> "Annotate images in directory :"
Output directory -> "Save processed images/masks to" (otherwise not clear what will be save in the output directory)
Save format -> "Save images in format" (I guess it's the processed ones)
I would put there the saving options for the mask too, to have a more homogeneous GUI with all saving settings in one place, and as said in teams the Save mask tick box and the dropdown for the format on the same line.
Save mask -> Save generated mask
Task : Here too not clear what "Rotation" and "centering" means if not familiar with the tool, so let's be ultra-explicit. Looks maybe overkill, and sure it increases the length of the macro-recorded command but who cares, that's what the recorder is for.
Rotation-> "Align object to desired orientation (below)" here the below refer to the orientation dropdownCentering-> "Move object to image-center"Centering + rotation-> "Center object and then align to orientation"Enlarge -> "Enlarge_canvas (prevent image cropping)", this one shoud record as enlargecanvas (mind the )
Object polarity -> "Alignement with object pointing to" -> ["Any", "Top (for vertical) / Left (for horizontal)", "Bottom (for vertical) / Right (for horizontal) "] Move this option just after orientation or even maybe next to it, since it anyway only makes sense when doing "Align to desired orientation".
Maybe you could actually have a header "Alignment settings" that would gather orientation, polarity and rotation center. And some ------ to finish that section (both using the addMessage from the GenericDialog class).
Comments specific to the batch annotation
I would move the save mask option just after the output directory, at the top : this is the first outcome of this annotation tool, at least chronologically for the user, the first things he does.
Then have a header introducing the "Image transformation settings"
And finally at the bottom the dropdown for the image format for saving the image. So it matches what happens in the tool, the image transformation and then the saving