sanketbajoria / ssh2-promise

ssh with promise/async await and typescript support
https://www.npmjs.com/package/ssh2-promise
MIT License
148 stars 24 forks source link

`specs/fixture.json` file is missing #29

Closed jlyonsmith closed 4 years ago

jlyonsmith commented 5 years ago

It is impossible to run the tests because there is no fixture.json file. It seems that it should contain a bunch of types of configuration. Presumably it was left out because there was passwords in there. If you could commit an example it would make it easier to reproduce. Plus then folks could actually test before submitting PR's!

sanketbajoria commented 5 years ago

@jlyonsmith Yes, you are right, i wasn't able to commit, because, it contains, actual server details. Let me commit few open server detail, which i can.

jlyonsmith commented 5 years ago

Thanks @sanketbajoria I have a small PR that I would like to submit but I would like to ensure that I haven't broken anything!

sanketbajoria commented 4 years ago

@jlyonsmith Integrated Travis ci, so if you raise a pull request, it should run the test cases automatically. For local testing, updated the Readme section.