search

sannajammeh / trpc-swr

tRPC-ified SWR hooks
https://trpc-swr.vercel.app
MIT License
209 stars 5 forks source link

docs(apps/docs): add favicon and social image #45

Closed r3nanp closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trpc-swr ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 11:13pm
changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 435b4947e3768b50c96ac8b6af87da13864103c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sannajammeh commented 1 year ago

Great stuff! Thanks for the PR. I see we need the open graph data for all pages, so removing the if check on the asPath would be preferred here. Set the title when asPath is === / to whatever you see fit, and otherwise leave it as it is. The rest of the openGraph is needed on all routes.

r3nanp commented 1 year ago

A small problem in this GitHub actions job: https://github.com/sannajammeh/trpc-swr/actions/runs/4997532792/jobs/8952024363?pr=45

Yep its a slight permissions issue due to forks. I'll look into it