search

sanni / cartreader

A shield for the Arduino Mega that can back up video game cartridges.
GNU General Public License v3.0
2.23k stars 226 forks source link

Arcadia dumping incorrectly #1013

Closed PsychoFox11 closed 3 months ago

PsychoFox11 commented 3 months ago

OSCR firmware version

14.0

OSCR hardware version

HW5 Rev5

Attach OSCR_LOG.txt file here

No response

System used

Emerson Arcadia 2001

Describe the issue.

Only one cart has been tested so far, but I hope to get more, and see an issue on this one. There is only one BIT incorrect in the dump. My AtariMax Maxflash dumps it correctly, matching the very old hash on No-Intro. OSCR just records a single bit wrong.

Here's a diff with the problem shown in red. Maxflash/No-intro on top, OSCR on bottom. As I hope to do more, and it's a fairly neglected system, I'd love to see this fixed! Dump is of the game "Tanks a Lot". I'm also fairly confident that a single bit error would not be caused by the adapter, and has to be software related.

image
sanni commented 3 months ago

Try adding a few additional NOP; here and see if that changes anything.

breyell commented 3 months ago

Try adding a few additional NOP; here and see if that changes anything.

Added a single NOP and that resolved the issue - thanks!

PsychoFox11 commented 3 months ago

Nice! (Just noting I filed this based on Bonzo's dump as he's making my adapter and borrowed my cart). So should be good!

PsyK0p4T commented 3 months ago

added that to code :) Thanks !