search

sanniassin / react-input-mask

Input masking component for React. Made with attention to UX.
MIT License
2.22k stars 257 forks source link

findDOMNode is deprecated; need to use a ref #166

Open joefiorini opened 5 years ago

joefiorini commented 5 years ago

Going to try to open a PR for this, but wanted to bring it up in an issue first. findDOMNode is deprecated in favor of refs. I think the safest way to fix this would be to create a single ref that is used in one of two ways:

  1. When using a render prop, pass the ref into the render prop function and require the developer to pass it down to their input (I believe there is precedence for this in other libraries, but need to verify that...)
  2. When not using a render prop, pass the ref straight to the default input that is controlled directly by the input mask component.

I'm going to try this and see what it does to the tests. If it works out, I'll open a PR for it, unless I hear objections here.

De-Santa commented 5 years ago

Need this feature to. Im using react-input-mask with react-datepicker and datepicker passes own onFocus handler to input. But my custom input wrapped inside with <div>, so I need input ref to handle focus properly. If I get ref as suggested in closed issues: ref={ref => this.input = findDOMNode(ref)} I get next eslint warns: image So it don`t feels like clean solution

skaziweb commented 4 years ago
Temirtator commented 3 years ago

I have the same problem. I send PR to fix this issue.

https://github.com/sanniassin/react-input-mask/pull/255