search

sanniassin / react-input-mask

Input masking component for React. Made with attention to UX.
MIT License
2.22k stars 258 forks source link

Incorrect README about maskChar #203

Closed IlyaCherkasov closed 4 years ago

IlyaCherkasov commented 4 years ago

Property maskChar, that is working, called maskPlaceholder in documentation. It would be better to update documentation for not confusing other people who wants to use this library.

gbarkhatov commented 4 years ago

@Cherkasik I've encountered this also. Please use "3.0.0-alpha.0" via "yarn add react-input-mask@3.0.0-alpha.0", as the default behavior is to install "latest" from npm. Which is 2.0.4

https://i.imgur.com/usqjZKv.png

gbarkhatov commented 4 years ago

Also, maskChar and maskPlaceholder are different things

IlyaCherkasov commented 4 years ago

Hmmm dev branch on master... Strange but whatever

gbarkhatov commented 4 years ago

@Cherkasik this is how all these JS libraries are done currently 😎Chaotic