Closed Temirtator closed 2 years ago
@LEMing yes, of course. There is no problem with build. I already checked.
Would love to have this one merged too 🙂
would be awesome to have that merged :smiling_face_with_three_hearts:
I fully support this MR
can you please consider to merge this
Please put this on live
Please, accept this PR.
Please merge, @sanniassin :)
@sanniassin, could you pretty please merge this?
Please merge this pull request, @sanniassin.
Please merge this pull request, @sanniassin.
How many people does it take to approve to merge this?
Any news?
@sanniassin Any news? Can we merge?
@sanniassin Can you merge this? We needing a lot.
@sanniassin Can you please merge?
This Pull Request has been open for a while. @sanniassin Will it be merged?
I'm closing this pr, since author of project does not respond for PR a long time.
As @pbarbiero I've forked this project to solve this problem. You can install it.
For those who are using version 2.0.4, here is a fork with the fix https://github.com/zenbill/react-input-mask/pull/1. The bundled files are in the repo too, so just point your package.json to our main
branch and you should be ready to go.
There's actually a fundamental reason why this PR can't be merged. It breaks the tests for passing in children:
function Input(props) {
return (
<InputMask mask="99/99/9999" value={props.value} onChange={props.onChange}>
<MaterialInput type="tel" disableUnderline />
</InputMask>
);
}
You need the findDOMNode
to find the <input>
DOM element within the <MaterialInput>
(or in my case a custom <Input>
functional component).
Currently, we get such a warning:
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of InputElement which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
This problem happens because findDOMNode method deprecated. So we don't need to use it.
This PR should solve this problem.