sanniassin / react-input-mask

Input masking component for React. Made with attention to UX.
MIT License
2.22k stars 256 forks source link

Caret moving to next to last position on Chrome android #51

Closed dusnoki closed 8 years ago

dusnoki commented 8 years ago

I have an issue with the component. When using it with a standard desktop web browser i don't have this issue. But on Android when the last character is entered (from the limit) the caret moves back 1 space.

You can see it I made a screen capture on my phone.

https://www.dropbox.com/s/2o2ltd35uca165b/2016_07_29_22_40_38_22_50_29_22_51_58_22_54_21_22_54_59.gif?dl=0

sanniassin commented 8 years ago

@dusnoki Need more info to reproduce:

Can you also try this pen – http://codepen.io/sanniassin/pen/vKVvVX to make sure it's not related to your code?

dusnoki commented 8 years ago

Device model: Note 4 (N910F) Android Version: 6.0.1 Marshmallow Browser version: Chrome 52.0.2743.98

I tried this pen and it also has the same results... caret moves one position back when last char is entered.

sanniassin commented 8 years ago

@dusnoki Thank you. I have no Android devices and can't reproduce this issue in Genymotion, so i need your help to fix it. Can you investigate into it and make a PR or find an emulator which will be able to reproduce?

dusnoki commented 8 years ago

I tried the codepen on firefox and android stock browser and they seem to work fine... Only chrome is giving me this issue. I'll try to investigate what is the problem.

IlanaB commented 8 years ago

I am also experiencing this issue. It's not reproducible in desktop but on Samsung Galaxy S7 Edge on Chrome v46. When adding the last character to the mask the cursor stays in the second last position and the field doesn't validate properly with the shown value.

sanniassin commented 8 years ago

@IlanaB @dusnoki Are you using native Android keyboard or TouchWiz one or something else?

IlanaB commented 8 years ago

@sanniassin I am using the native keyboard

sanniassin commented 8 years ago

@IlanaB @dusnoki Is it fixed in this pen? http://codepen.io/sanniassin/pen/dXAvyd

IlanaB commented 8 years ago

I'm struggling to use that pen from my device. It's hiding the input field so I can't see it as I am typing Is it possible to add some space to the bottom below the input so that i can scroll down?

On Tue, 16 Aug 2016 at 15:38 sanniassin notifications@github.com wrote:

@IlanaB https://github.com/IlanaB @dusnoki https://github.com/dusnoki Is it fixed in this pen? http://codepen.io/sanniassin/pen/dXAvyd

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sanniassin/react-input-mask/issues/51#issuecomment-240213749, or mute the thread https://github.com/notifications/unsubscribe-auth/ADcAAQXEDteGHuMDRjGyK1CnzhqbxVNmks5qghGggaJpZM4JYkkZ .

sanniassin commented 8 years ago

@IlanaB Usually rotating phone to landscape helps. I've also commited fix so you can try it in your project.

sanniassin commented 8 years ago

@IlanaB @dusnoki Does it working fine now?

IlanaB commented 8 years ago

@sanniassin I won't be able to confirm until next week, thank you for looking into this so quickly though!

sanniassin commented 8 years ago

@IlanaB You're welcome. I'll wait, just want to be sure before publishing update on npm.

sanniassin commented 8 years ago

@IlanaB @dusnoki I'll close this issue as it seems to be fixed. Let me know if it not.

dusnoki commented 8 years ago

@sanniassin it is working fine in the new codepen. Thnx for the fix guys :)