search

sannybuilder / dev

Sanny Builder Bug Tracker and Roadmap development
https://sannybuilder.com
49 stars 0 forks source link

First mission in GTA VCS PSP is not playable with a custom main.scm #56

Closed x87 closed 4 years ago

x87 commented 4 years ago

Got a report that you can't get back to the army base in the first mission of GTA VCS. Investigating.

x87 commented 4 years ago

The issue is found. Both GTA LCS and GTA VCS use different numbering system for compound conditions. Previously the parameter in the IF instruction was off by 1 than the number of underlying conditions, now they match:

GTA 3, VC, SA:

if 1
 cond1
 cond2
jf

GTA LCS, GTA VCS:

if 2
  cond1
  cond2
jf

Feel dumb for not knowing that for so many years 😞 Learned it the hard way.

x87 commented 4 years ago

The issue is only reproducible with Check conditions on, as otherwise the disassembler keeps the IF number in place.