sanoojes / Spicetify-Lucid

A Dynamic, Highly Customizable Spicetify theme inspired by Bloom and Microsoft Fluent Design.
https://sanooj.is-a.dev/Spicetify-Lucid/
MIT License
126 stars 3 forks source link

UI suggestion for title bar #44

Closed LuminarySage closed 3 months ago

LuminarySage commented 3 months ago

Is your feature request related to a problem? Please describe. When the main pane is scrolled down, the title bar becomes brighter, which I understand as you're trying to convey layout hierarchy but it looks kinda bad with no padding at all to any of the panes. This is especially noticeable when playing songs with cover art using bright colors

Describe the solution you'd like A very obvious and straightforward solution is to add some padding to the bottom of the title bar. Although I suggest removing the title bar brightening altogether as there's nothing scrolling under it, so there's no need to convey depth here.

Additional context Default: image

Main pane scrolled: image

sanoojes commented 3 months ago

oops sorry for the issue i didn't notice that because of the controls i will add a padding there

sanoojes commented 3 months ago

image image

i think there is enough padding there

sanoojes commented 3 months ago

and on the bottom its intentional as the window controls are transparent

LuminarySage commented 3 months ago

I was gonna report that one too but I was actually talking about this image

LuminarySage commented 3 months ago

Also play a song with a cover art with really bright colors and then scroll down to see what I mean by "title bar brightens when scrolled"

sanoojes commented 3 months ago

I was gonna report that one too but I was actually talking about this image

yes that was intentional there is some issues with some colors will try to add a fix for it

sanoojes commented 3 months ago

can you add a screenshot of the issue it will be much easier for me to check that

sanoojes commented 3 months ago

Also play a song with a cover art with really bright colors and then scroll down to see what I mean by "title bar brightens when scrolled"

its not a brightness effect but a change in saturation i will fix that issue

LuminarySage commented 3 months ago

can you add a screenshot of the issue it will be much easier for me to check that

I did in the original report

LuminarySage commented 3 months ago

Oh I was gonna do a screen recording but it seems like you fixed it already 😅

sanoojes commented 3 months ago

reverted the fix cause it has some issues with global nav