sanoojes / Spicetify-Lucid

A Dynamic, Highly Customizable Spicetify theme inspired by Bloom and Microsoft Fluent Design.
https://sanooj.is-a.dev/Spicetify-Lucid/
MIT License
100 stars 4 forks source link

Window Control Buttons do not blend in with the theme in full screen mode while using "Full Screen" extension by daksh2k #49

Closed deb12378 closed 1 month ago

deb12378 commented 2 months ago

Do you have the latest versions of Spicetify, Spotify and Lucid?

Is there already an issue for your problem?

Is your problem definitely caused by the theme?

Environment & Computer Info

- Spotify version: Spotify for Windows (64 bit) 1.2.41.434.g39a25e2c
- Installed from: Spotify site
- Spicetify version: v2.36.15
- Color scheme: Lucid / dark
- Extensions: adblock.js, fullScreenWrapper.js, theme.js
- Custom apps: lyrics-plus, new-releases, reddit
- Lucid installation method: PowerShell script

Description

  1. Install the extension "Full Screen" by daksh2k from the Marketplace.
  2. Go into full screen using the new full screen button or by hitting the shortcut T or F.
  3. Check the top right corner for the window control buttons.

The window controls should blend in like it does when not in full screen but it doesn't.

Screenshots

Screenshot (136)

sanoojes commented 2 months ago

oops soory to cause an issue i will fix it right now !

sanoojes commented 2 months ago

can you update the theme and check if using marketplace just restart spotify and check @deb12378

deb12378 commented 2 months ago

@sanoojes Thank you for such a prompt fix. It's exactly what was required. Just a little doubt, I can see that the controls are still there, it just isn't visible as it now blends in perfectly. I don't know if it will look good or not but what if the buttons were still visible but also blended with the background like it appears on the homepage like this. Attaching both the homepage and the full screen. image

image

sanoojes commented 1 month ago

@sanoojes Thank you for such a prompt fix. It's exactly what was required. Just a little doubt, I can see that the controls are still there, it just isn't visible as it now blends in perfectly. I don't know if it will look good or not but what if the buttons were still visible but also blended with the background like it appears on the homepage like this. Attaching both the homepage and the full screen. image

image

if the buttons were visible it will not be transparent we cant figure out that i will try to find a way to fix that soon

full screen view in beautiful lyrics image

cinema view in beautiful lyrics Screenshot 2024-07-17 111239

window controls will not be transparent in this state

deb12378 commented 1 month ago

I was actually asking for something like this. Look at how the window controls are visible and yet they are consistent with the overall background of the theme. Just need to achieve this even in full screen. Screenshot (137)

ohh i see the extenstion does that it forces it to be fullscreen so it does not show controls

sanoojes commented 1 month ago

image

do you mean something like this ? if yes its not from the theme i think you should make a issue on that extention requesting fullscreen with controls

deb12378 commented 1 month ago

Yes I meant something like that only just that I wanted it to have only the symbols and not the rectangular boxes enclosing them. Like I wanted the ( -, 🗖, X) only and not the boxes enclosing them which cause it to be different from the background.

deb12378 commented 1 month ago

Sure I'll just raise an issue with the full screen extension repo.