search

sanoopsivan / jsmpp

Automatically exported from code.google.com/p/jsmpp
Apache License 2.0
0 stars 0 forks source link

Delivery reciept generation is broken #7

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi,

It seems there is a problem in DeliveryReceipt.toString() method.
First, a typo where you use DELREC_STAT instead of DELREC_ERR. 
And second, just a suggestion. In my opinion, field lengths should be
limited while generating text. For example ERR should be 3 octets exactly,
but you can pass any value to the constructor, and it will get to delivery
receipt text unchanged. Sure, programmer who uses library could check that
before creating object, but imho library should do it.

Original issue reported on code.google.com by hudb...@gmail.com on 1 Sep 2008 at 12:45

GoogleCodeExporter commented 8 years ago 
Thanks again, already fixed.

Original comment by uuda...@gmail.com on 2 Sep 2008 at 7:35