Broken with dark theme - Githubissues

sanpii / effitask

Graphical task manager, based on the todo.txt format.

MIT License

225 stars 15 forks source link

Broken with dark theme #30

Open geek-merlin opened 5 years ago

geek-merlin commented 5 years ago

What are the minimum necessary steps to reproduce this issue?

Use effitask (on ubuntu) with dark theme.

What happens?

everything looks good
until messages appear, they are "white on white"
until i set a rask's priority... task is now "white on white" (and needs manual change of todo.txt due to #28)

What were you expecting to happen?

Use dark colors. …

sanpii commented 5 years ago

Do you have a screenshot?

geek-merlin commented 5 years ago

see #29

kogic1 commented 5 years ago

Hi, I have the same issue. I tried overwriting the "./resources/style_light.css" with "style_dark.css" before running make and no difference. Do you know which file I should be editing? I couldn't find any other references to the color F8D7DA, which is the one that makes it unreadable to me. https://www.color-hex.com/color/f8d7da

Screenshot from 2019-09-05 22-39-55

sanpii commented 5 years ago

It’s like a dark theme doesn’t detected as dark.

What is your theme?

You can add :dark at you theme name to force the dark style. For example:

GTK_THEME=Clearlooks:dark todo et

Produce the opposite effect: a clear theme with the dark stylesheet.

kogic1 commented 5 years ago

Hey, thanks for the ultra quick response! I'm using the default one in Manjaro Cinnamon, Mint-Y-Dark-Teal. I tried running "export GTK_THEME=Mint-Y-Dark-Teal:dark" and that did not change the issue. Is that what you meant to do?

How come I executed at ./target/release/effitask after editing the styles.css files and it didn't change in the program?

Thanks!

sanpii commented 5 years ago

Is that what you meant to do?

Yes.

How come I executed at ./target/release/effitask after editing the styles.css files and it didn't change in the program?

In release mode, the files are loaded from ~/.local/share/effitask/ or /usr/share/effitask/. If you want to load files from sources, execute ./target/debug/effitask.

It’s probably nice to enable dark theme: https://askubuntu.com/a/806745

I just made a little fix (https://github.com/sanpii/effitask/commit/8da8c9b1afb0e1b132f0e2e56f9466e4eebd05bd) but it’s probably change nothing.

kogic1 commented 5 years ago

Hey Sapii. Ok so I overwrote the CSS files and it looks great. I'm using Cinnamon, so I would need to install the while Gnome desktop environment to do that, tried editing the config file and it doesn't exist. Anyone, for me it fixed it, so thank you!