sanpingz / mysql-connector

Deprecated, use mysql-connector-python instead
https://pypi.org/project/mysql-connector-python/
Other
37 stars 8 forks source link

2.2.3 Protobuf C++ Dependency? #4

Open remingtonc opened 7 years ago

remingtonc commented 7 years ago

For the unfamiliar (such as myself), what is the reason that Protobufs are now a required dependency? I see also that it is in the upstream as well, but no detail as far as I can see.

sanpingz commented 7 years ago

@remingtonc This repo just like a mirror to https://github.com/mysql/mysql-connector-python. Please refer to https://github.com/mysql/mysql-connector-python/commit/01a9bd5514b9b8bb8b93b5af440e4cbd60fa74ce for more details. Personally, I also don't like the additional dependency.

Anthchirp commented 7 years ago

They unfortunately don't use the GitHub issue tracker

Anthchirp commented 7 years ago

Link to related MySQL bug: https://bugs.mysql.com/bug.php?id=85666

cuilc commented 7 years ago

protobuf 3.2.0, when i use mysql-connector-2.1.4, installed successfully, when i install mysql-connector-2.2.3, it failed, message as bellow: creating build\lib.win-amd64-2.7\mysqlx\locales copying lib\mysqlx\locales__init__.py -> build\lib.win-amd64-2.7\mysqlx\locales creating build\lib.win-amd64-2.7\mysqlx\locales\eng copying lib\mysqlx\locales\eng\client_error.py -> build\lib.win-amd64-2.7\mysqlx\locales\eng copying lib\mysqlx\locales\eng__init__.py -> build\lib.win-amd64-2.7\mysqlx\locales\eng **running build_ext

Python architecture: 64-bit

# Python ARCH_64BIT: True
Unable to find Protobuf include directory.**
remingtonc commented 7 years ago

@cuilc This is resolved by installing the new protobuf dependency. Here's an example with Ubuntu in another issue, and an example with MacOS.

remingtonc commented 7 years ago

@sanpingz So it's a way of getting around Python 2/3 compatibility with pure Python protobuf implementation?

sanpingz commented 7 years ago

@remingtonc I believe there is, looks like 2.2.x is still not stable, and introduced ungraceful dependency, I will suggest use 2.1.x instead until it gets stable. pip install mysql-connector==2.1.6