search

sanposhiho / gomockhandler

Mr. gomockhandler is the clever and more agile manager of golang/mock (uber/mock) 👔
MIT License
105 stars 8 forks source link

configuration file is not readable #59

Closed sanposhiho closed 2 years ago

sanposhiho commented 2 years ago

Now, we support configuration gomockhandler.json.

And to add new mock on config, users have to execute cmd like this, and config for new mock will be added on gomockhandler.json. gomockhandler -config=/path/to/gomockhandler.json -source=foo.go -destination=./mock/ [other mockgen options]

But, PR reviewers cannot see what command will be registered, and it makes PR review a little hard.

So, I want to add new optional configuration file or add information on config file to resolve this.

sanposhiho commented 2 years ago

I think we can resolve this by splitting gomockhandler.json into two file. The one is to manage mock information (= configuration file) and the other one is to manage the status of each mock. With this, we can make configuration file(the first one) more readable. And we can allow user to edit configuration file directly (= user can edit configuration without CLI)

close this issue and open another enhancement issue.