search

sanskarmalkhede / calculator

A standard calculator made using Javascript.
https://sanskarmalkhede.github.io/calculator/
1 stars 5 forks source link

Basic CSS changes #18

Closed madm234 closed 1 year ago

madm234 commented 1 year ago
  1. I have changed overall css ,you can see in the attached image.
  2. In input box numbers now appears from right to left(according to a basic real-life calculator).
  3. 'Numbers' and 'equals to' color changed so that they look different from others.
  4. Responsive.

image

madm234 commented 1 year ago

@sanskarmalkhede If you liked this design do merge this under hactoberfest. If not ,then suggest the changes.

sanskarmalkhede commented 1 year ago

The overall design looks good👍 But I think the color palette looks like every other calculator app out there. If possible use a popping color palette.

madm234 commented 1 year ago

The overall design looks good👍 But I think the color palette looks like every other calculator app out there. If possible use a popping color palette.

Sure. I only chose this background color cause I found it a descent dark color. However I would now change it to popping one.

madm234 commented 1 year ago

@sanskarmalkhede Is it fine now?

image

sanskarmalkhede commented 1 year ago

Yes it look good. But there is scope for improvement. Good job 👍 Your PR will be merged. Make sure to star the repo. Happy coding...