pate 570,1—3

[gasyoun]

Not only 1 should be linked, but interval until 3 us well. Regex did not catch it, @funderburkjim

[funderburkjim]

In this case, I don't see any real problem -- if the user clicks the link to 570,1 then verses 2 and 3 will be visible.

[gasyoun]

if the user clicks the link to 570,1 then verses 2 and 3 will be visible.

Sure he will, but the 3 is bigger than 1, but should be same size font.

[funderburkjim]

In the scans, the '1' is NOT smaller. All the digits are same size

So there should be TWO adjustments:

1. include the '3' in the link (570,1—3 all underlined)
2. Have all digits the same size (the '1' not smaller).

@gasyoun Agree?

[funderburkjim]

You also noticed a case where a rare AV reference was wrongly treated as a RV reference.

Which issue is this?

[gasyoun]

In the scans, the '1' is NOT smaller. All the digits are same size

Same size in print, not in our digitization.

So there should be TWO adjustments

Agree.

a rare AV reference was wrongly treated as a RV reference.

https://github.com/sanskrit-lexicon/GRA/issues/3

[funderburkjim]

@gasyoun I found the AV issue -- it is #3.

[gasyoun]

it is #3.

Oh yes it is.

[funderburkjim]

Have added markup to gra.txt for the RV references. Examples

• {494,1};
• vāstos {570,1—3}
• {798,2. 4. 17}

Altered display code to handle this markup: basicadjust.php

Also, Unmarked the AV references, so they won't be erroneously linked to RV (#3)

Also, greatly reduced the unlinked RV references, and extended the scope of the link text (#5).

[funderburkjim]

Tech doc

Here are the required files to do the revision to gra.txt. They are run in a temp_ls subdirectory of csl-orig/v02/gra/.

The files are in this gist.

The files briefly described:

• readme.txt repeatable instructions
• rvmarkup.py program applies markup to {xxx,x} and similar instances. This gets most, but not all markup.
• avmarkup.py Remove the {xxx,x} markup for AV links
• filter1.py Search for a few anomalous cases and generate prototype change transactions
• filter1_edit.txt Manually corrected change transactions based on output of filter1.py. Also, a few additional changes noticed along the way
• rvmarkup1.py {xxx,x} markup occurring at beginning or end of lines. (These were missed by rvmarkup

[funderburkjim]

Further work that could be done.

Currently, the xml form (gra.xml) contains {xxx,x} markup.

The conversion of these links to the 'modern' links is done on the fly by basicadjust.php.

It might be better to

• do the conversion to modern links in make_xml.py .
  For example, instead of {570,1} in gra.xml, we might have <ls n="rv07.054.01">570,1</ls>
• and then basicadjust would be much simpler by using this rv07.054.01 attribute value.

This change would

• make the display program less complex
• make gra.xml more informative
• provide a form that could more readily be extended to cover the AV links (#3)

[gasyoun]

instead of {570,1} in gra.xml, we might have 570,1

Makes sense, but if Jim will not, nobody will. Otherwise the different basicadjust.php will always remain such.

[funderburkjim]

if Jim will not, nobody will

This is a persistent problem. There are too many potential improvements that currently depend on me for implementation.

[gasyoun]

too many potential improvements that currently depend on me for implementation

Let's have a Skype call. I guess I have a guy, but we are a bit away of the December plan because of too much MW addenda lately ))