Closed funderburkjim closed 3 years ago
All the 2020 dictionaries have been recreated using this template,
Before doing this, a copy of the previous versions of the various xxx.xml was saved (in scans/a_ejf/oldxml).
Then the dictionaries were recreated using the make_xml.py template and the various new xxx.xml compared to the previous. And there were no material differences.
<s>
tag. So is not material. For example:
(under anurudDa, the two versions differ only between </s>— <s> tri
and </s>—<s> tri
--- clearly not material differences.Congratulations Jim. Now with more and more code being templated, we are moving towards the long coveted goal of unified code base at unprecedented speed.
Data and code both on github will help all contributors - correction submitters and code patch submitters.
It's a major milestone. Since August Jim has been working at double speed to get a barebone clear version of old code and architecture. Hope @YevgenJohn will be able to help soon enough.
In the previous revision of csl-pywork, make_xml.py was in 'distinctfiles'. That is, when reconstructing a 2020 dictionary, csl-pywork used a separate version of the make_xml.py program for each dictionary. Now, csl-pywork uses one make_xml.py template to create the different versions.
This is an improvement, because now we can see all the variations in one place. Also, we will be able to modify this template so that it generates code that is compatible with both python2 and python3 (Note the current template has not yet been modified for this compatibility.)