sanskrit-lexicon / csl-websanlexicon

0 stars 1 forks source link

disp.php -> basicdisplay.php #4

Closed funderburkjim closed 4 years ago

funderburkjim commented 4 years ago

The file currently named webtc/disp.php contains the class BasicDisplay. As might be expected, this class is responsible for generating most of the HTML code for the Basic Display of the various dictionaries.

In the apidev code (ref https://github.com/sanskrit-lexicon/csl-apidev/), an exact copy of disp.php is renamed to a (more logical) basicdisplay.php.

Several small changes are made to csl-websanlexicon to simplify naming.

funderburkjim commented 4 years ago

rename disp.php

Change documentation relative to csl-apidev.

in readme_xampp.org, down in the 'apidev' section, the last instruction was to copy the csl-websanlexicon/v00/makotemplates/webtc/disp.php to apidev as basicdisplay.php.
Since we've changed the name of .../webtc/disp.php to .../webtc/basicdisplay.php, we need to change the instruction in readme_xampp.org file to

cp ../csl-websanlexicon/v00/makotemplates/webtc/basicdisplay.php basicdisplay.php

Change inventory.txt

funderburkjim commented 4 years ago

Finish installation

install in one dictionary and check

As a check, install for some dictionary (e.g. vcp), and check basic display and advanced search.

python generate.py vcp inventory.txt  makotemplates ../../VCPScan/2013/web

Displays look normal. Assume changes are good.

Install for all dictionaries

In csl-websanlexicon/v00, run the installation script:

sh redo_cologne_all.sh

double check MW

since the dictionary is used so often 👍

funderburkjim commented 4 years ago

delete old copy of disp.php from webtc

The above steps leave one detail incomplete. Namely, there is now a copy of disp.php in the web/webtc directory for each dictionary. Since disp.php is an orphan (no program calls it any longer), it should be deleted. Will do the necessary to fix this problem tomorrow.

gasyoun commented 4 years ago

Crystal clear documentation as usual.

funderburkjim commented 4 years ago

finish deletion of disp.php