sanskrit-lexicon / csl-websanlexicon

0 stars 1 forks source link

Homonym repetition in pwg display #41

Closed funderburkjim closed 2 weeks ago

funderburkjim commented 2 weeks ago

This issue fixes a bug present in the Cologne displays for pwg.

Here is how the bug looks in the Basic display.

image

It also occurs in the simple search display.

funderburkjim commented 2 weeks ago

A one-line change in basicadjust.php solves the problem for pwg in the basic, list, etc. displays. Copying basicadjust.php to csl-apidev repo also fixes the bug in simple display.

Here's basic display as fixed:

image
funderburkjim commented 2 weeks ago

Currently, the '1.' and '2.' in pwg.txt are not marked with the hom tag. If this tagging is done, then we would see these hom numbers in red, with a tooltip.

Andhrabharati commented 2 weeks ago

@funderburkjim

As I had mentioned elsewhere (issue 68 in PWG), this issue is seen in some other dictionaries as well; for e.g. both the Cappeller's dictionaries have it.

So you need to add those all in the "array" in your code.

funderburkjim commented 2 weeks ago

script to get dictionaries with <h>

dirorig='/c/xampp/htdocs/cologne/csl-orig/v02/'
for dictlo in  acc ae ap90 ben   bhs bop bor bur cae \
 ccs gra gst ieg inm  krm mci md mw mw72 \
 mwe pe pgn pui    pw pwg sch shs skd \
 snp stc vcp vei wil  yat lan armh
do
 xxx="$dirorig/$dictlo/$dictlo.txt"
 nh=`grep '<L>.*<h>' $xxx | wc -l`
 echo "$dictlo $nh"
done

Output:

acc 0
ae 0
ap90 9
ben 0
bhs 94
bop 793
bor 0
bur 0
cae 2560
ccs 1796
gra 36
gst 25
ieg 0
inm 4298
krm 0
mci 319
md 920
mw 16443
mw72 3657
mwe 0
pe 2909
pgn 0
pui 7339
pw 0
pwg 6431
sch 0
shs 0
skd 0
snp 0
stc 1150
vcp 0
vei 314
wil 0
yat 0
lan 209
armh 0
funderburkjim commented 2 weeks ago

Additional dictionaries adjusted in display.