Build package - Githubissues

sanssouci-org / IIDEA

Interactive Inference for Differential Expression Analyses

GNU General Public License v3.0

0 stars 1 forks source link

Build package #1

Closed nicolas-enjalbert closed 11 months ago

nicolas-enjalbert commented 1 year ago

Build package and add the first version for IIDEA

pneuvial commented 1 year ago

Thanks!

Please update the DESCRIPTION file according to requirements.txt, some packages need to be imported from

pneuvial commented 1 year ago

Some of the functions in R/fct_post-hoc.R are pasted from the sanssouci package. Since the package already imports sanssouci, why not using these functions directly? In the case of curveMaxFP, currently it is not exported but we could export it in the next release if necessary.

pneuvial commented 1 year ago

I've only reviewed the functions in ShinyApp for now. Hope to do the rest soon.

pneuvial commented 1 year ago

Thanks for the updates. The package passes R check with 3 NOTES. I've fixed one (adding files to .Rbuildignore) but there are still issues with

external functions should be imported from
calls to 'data' (not sure what is the best way to fix this)

Can you fix these issues? We can discuss the 2nd one if needed.

pneuvial commented 11 months ago

Thanks. I thnik we should export curveMaxFP and formatBounds in sanssouci, so that we can use them here.

nicolas-enjalbert commented 11 months ago

@pneuvial I think the pull request can be merged. What are you thinking about it ? Thanks.