first test_curve_max_fp

sanssouci-org / sanssouci.python

Post hoc inference via multiple testing

GNU General Public License v3.0

6 stars 3 forks source link

first test_curve_max_fp #10

Closed nicolas-enjalbert closed 3 years ago

nicolas-enjalbert commented 3 years ago

Start of test for the curve_max_fp function

pneuvial commented 3 years ago

An interesting test to add: the last element of the vector returned by curve_max_fp should be identical to the return value of max_fp

nicolas-enjalbert commented 3 years ago

I have added the test on the last element of curve_max_fp.

I also have added the continuous integration action of pytest. This action is activate on push and pull requeste only on the branch 'main'.

pneuvial commented 3 years ago

Nice!

bthirion commented 3 years ago

Thx for this great addition ! May I suggest to leave a bit of time ---say 24h --- before merging, so that other onctributors have a chance to jump in and comment ? Best,

pneuvial commented 3 years ago

Sorry about this Bertrand! Sure, we should be able to find an acceptable compromise between 6 hours and one month :)