sanssouci-org / sanssouci.python

Post hoc inference via multiple testing
GNU General Public License v3.0
6 stars 3 forks source link

Avoid double sorting in max_fp and curve_max_fp #25

Closed pneuvial closed 2 years ago

pneuvial commented 3 years ago

This looks very suboptimal:

https://github.com/pneuvial/sanssouci.python/blob/29e99a35eeea673eb4802fe9bf6ee4b12c49011b/sanssouci/post_hoc_bounds.py#L41-L44

Is there any good reason not to replace the above lines by

thr = np.sort(thr)

?

pneuvial commented 2 years ago

No good reason found!

pneuvial commented 2 years ago

Will be addressed by #40