search

sanssouci-org / sanssouci.python

Post hoc inference via multiple testing
GNU General Public License v3.0
6 stars 3 forks source link

error in max_fp and curve_max_fp #43

Closed alexblnn closed 2 years ago

alexblnn commented 2 years ago

there is a slight error in both functions : strictness of inequalities is wrong. Should be a large inequality at https://github.com/pneuvial/sanssouci.python/blob/main/sanssouci/post_hoc_bounds.py#L64 and a strict inequality at https://github.com/pneuvial/sanssouci.python/blob/main/sanssouci/post_hoc_bounds.py#L189

alexblnn commented 2 years ago

btw this doesn't change anything in usual cases but with discrete p-values it can lead to problems.

alexblnn commented 2 years ago

fixed by commit