Wrong assumption in find_largest_region

sanssouci-org / sanssouci.python

Post hoc inference via multiple testing

GNU General Public License v3.0

6 stars 3 forks source link

Wrong assumption in find_largest_region #45

Closed alexblnn closed 2 years ago

alexblnn commented 2 years ago

The line region_size = len(res[res > tdp]) assumes that res is a decreasingly sorted array, such that the maximum region size is equal to the number of regions verifying the condition, which is false.

alexblnn commented 2 years ago

fixed by commit