search

sanssouci-org / sanssouci

Post hoc inference via multiple testing
https://sanssouci-org.github.io/sanssouci/
10 stars 3 forks source link

[volcanoPlot] Adapts volcanoPlot.method and volcanoPlot.numeric for different test bewteen vp and bounds #66

Closed nicolas-enjalbert closed 3 years ago

pneuvial commented 3 years ago

Issue with this solution: inconsistency between the first arguments of volcanoPlot.sansSouci and volcanoPlot.numeric.

pneuvial commented 3 years ago

One possibility is to keep the object in 'x' and call the other arguments p_values and fold_changes.

This is not optimal because the 'x' argument of the volcanoPlot method will represent two different things in the methods volcanoPlot.sansSouci and volcanoPlot.numeric. But maybe not too bad since volcanoPlot.numeric is not exported...

pneuvial commented 3 years ago

Let's merge (and keep this branch for some time)