search

santalu / empty-view

A view that displays state of screen like loading, error, empty
Apache License 2.0
377 stars 46 forks source link

Add more annotations + revert constants in annotations interface #10

Closed Gounlaf closed 6 years ago

Gounlaf commented 6 years ago

@santalu I figured out moving constants into annotation interfaces was a really bad idea . It works in Java, but it's a pain in the ass in Kotlin. Keep constants outside the annotation interface (called "annotation class" in Kotlin) is really better.

So I rollback commit 9a57160f827ca65c013aa7256e9ccdd43347b987, keeping annotation and prefixing constants.

I also add lot of annotations on fields.

Regards.

santalu commented 6 years ago

Hi can you please try 1.0.5 and tell me about the regarding issues on Kotlin whether fixed or not? Thanks in advance.

Gounlaf commented 6 years ago

@santalu it's better :)

santalu commented 6 years ago

Glad to hear! Have a good day.