Add "emptyview_" prefix to strings and dimensions

santalu / empty-view

A view that displays state of screen like loading, error, empty

Apache License 2.0

377 stars 46 forks source link

Add "emptyview_" prefix to strings and dimensions #3

Closed Gounlaf closed 7 years ago

Gounlaf commented 7 years ago

Prefix strings resources and dimensions resources with emptyview_, avoiding conflict/unwanted overrides when using the library

santalu commented 7 years ago

Thank you for your contribution. But about the errors isn't it better users to override and customize them? These are just defaults.

Gounlaf commented 7 years ago

Hi @santalu,

The "problem" is that you provide, IMO, too "generic" named strings/dimensions. It's highly probable to have a string error_connection_not_found (as example) defined in a project.

By prefixing, it's more safe:

developers will not have strange behaviour if they doesn't import library in "correct order"
it will be easy to find which strings/dimensions to override, because they are prefixed