search

santiago-hollmann / igcparser

Project which includes an Android library to parse IGC files and an Android app called IGC Viewer to analyze them.
MIT License
15 stars 9 forks source link

Fix IGC date parsing to support the new format. #74

Open tomifischer opened 3 years ago

tomifischer commented 3 years ago

Hi there! Fellow Argentinian and flight enthusiast here :) I've enjoyed your app so far but I was a bit annoyed that the track logs were not being shown in order, which I guessed was related to the parser not being able to cope with the new IGC date format as brought up in issue #65. I wrote a small patch that should allow for both the old and new date formats to be parsed properly. This in turn fixed the log display order.

BTW Not really related to this issue, but to be able to build your project on Android Studio 4.1.3 I had a few troubles.

  1. From the quick looks of it, Fabric seems to have been taken over by Firebase for a while and does not seem to be compatible with the latest android SDK, so I just got rid of all the crashlytics references locally to get it working. On the same note, I don’t think the Setup -> Setup Fabric section of the README is relavant anymore.
  2. Then I was greeted with the following message 
    Gradle sync failed: Unsupported method: SyncIssue.getMultiLineMessage().
The version of Gradle you connect to does not support that method.
To resolve the problem you can change/upgrade the target version of Gradle you connect to.
Alternatively, you can ignore this exception and read other information from the model.

    Which I solved (following this SO thread by updating build.gradle to read

    classpath 'com.android.tools.build:gradle:4.1.3'

    and gradle-wrapper.properties to

    distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip

Not really an Android or Java user, so let me know if you think something is in need of tuning.

s-celles commented 3 years ago

Hello @tomifischer As you can see on https://github.com/santiago-hollmann/igcparser/pulls ... PR are not merged nor commented. @santiago-hollmann doesn't seem to be active on Github anymore. That's sad because that's a nice open source software. Maybe some of us should consider to fork this project and give it new life.

s-celles commented 3 years ago

Issues https://github.com/santiago-hollmann/igcparser/issues are not commented also.

tomifischer commented 3 years ago

Hi @scls19fr, I did notice that there does not seem to be any github activity on his part for the past years, I might try reaching out in another way if I get no response in the following days. If he is not interested in maintaining this project further, we could indeed fork and get it running again.

s-celles commented 3 years ago

Hi @tomifischer did you get some news from @santiago-hollmann ?

tomifischer commented 3 years ago

Hi @scls19fr. I tried but couldn't get in touch by email either. I'd be happy to collaborate on getting this running again if you'd like. Feel free to email me privately if you are still interested and we can try to make a plan.