Events handling modification

santigimeno / node-ewmh

Implementation of the Extended Window Manager Hints (EWMH)

ISC License

18 stars 1 forks source link

Events handling modification #6

Closed santigimeno closed 10 years ago

santigimeno commented 10 years ago

As this module is mainly intended to be used by WMs, in order to notify client requests of HINTS modifications we listen for ClientMessage events.
Modify ActiveWindowChange event to ActiveWindow.

santigimeno commented 10 years ago

@sidorares this PR is somehow related with the comment I made about this module to be used by WM's.

Also, I feel that with this change, the modification of the event mask in the root window is not a problem anymore, as every window manager is going to set SubstructureRedirect in the root window

sidorares commented 10 years ago

Why do you want to set SubstructureRedirect? Can we just assume that it is already set if we need to listen for specific request (do we? MapRequest, ConfigureRequest, UnmapRequest etc)

santigimeno commented 10 years ago

I set it just in case the window manager hasn't already set. Yes it's unlikely but I think it doesn't hurt. Maybe I can check if it's already checked before setting it.

sidorares commented 10 years ago

If another wm is running changeattributes request will fail. Maybe add callback and check for BadMatch error?

santigimeno commented 10 years ago

I'm assuming the only wm running is the one using the module.

I've been thinking about the purpose of the module, let me try to explain (and please correct me if I'm wrong)

From what I understand, the operations related to EWMH to be performed by WM's and clients are different:

WM's receive requests from clients via ClientMessage events and decide to honor them or not. This functionality is implemented in the module (after this change) via events and setters respectively.
Clients request WM to perform certain operations (via SendEvent) and they can listen for events to know if they've been performed or not.

You said in another thread that most operations between WM's and clients are shared. Which operations are those?

So I've been thinking that operations for WM's can be implemented in this module and operations for clients in another (symetric). Or have both in this module but diferent exports.

Thoughts?

santigimeno commented 10 years ago

Regarding my long comment, now I see there are common functions between client and wm's. I'm still not sure we should make this module work for both client and server though.

santigimeno commented 10 years ago

@sidorares I'd like to include this PR and make a release. Do you have any objection or comment?

sidorares commented 10 years ago

No objections about your PRs - please merge everything if you happy with changes

sidorares commented 10 years ago

Regarding your comment - let's add features we actually going to use. I started writing simple composite manager, hence my cm-owner pull request. I'd also like to integrate some of ewmh functionality with @dominictarr tiles wm

santigimeno commented 10 years ago

Yep, I agree. The composite manager thing sounds great. Are you planning supporting transparency? Let me know when you have something.

sidorares commented 10 years ago

Yes, with transparency. Initially using xrender (all requests already available) and then with glx (need to figure out how to create texture out of pixmap)

santigimeno commented 10 years ago

I think compiz does it with glx