search

santigimeno / node-pcsclite

Bindings over pcsclite to access Smart Cards
ISC License
170 stars 125 forks source link

Removed buffertools dependency #62

Closed Klemen1337 closed 5 years ago

Klemen1337 commented 7 years ago

Buffertools are not needed anymore because of Node.js Buffer.

santigimeno commented 7 years ago

Thanks for the PR. Yes, I've been thinking about it for a while. The only stopper is that we would drop support for 0.10.x and 0.12.x versions. If this is merged it should be in a major. Let me think a little about it.

santigimeno commented 7 years ago

OK, I'd like to include this PR before publishing 1.0.0. This will mean we stop supporting 0.10.x and 0.12.x versions but I'm fine: they can always use the 0.4.x versions. @Klemen1337 Could you address the comment so I can merge this? Thanks for your contribution!

santigimeno commented 5 years ago

Finally went for the @pokusew solution. This should be fixed in version v1.0.0.