gap in MKR prices

[josefansinger]

The metric daily_avg_price_usd for the slug maker is available since 2017-01-29. But you report no price data for the first months. Would it be better to report 2018-05-30 as availableSince when MKR did hit the exchanges?

[IvanIvanoff]

Our pricing data comes from coinmarketcap and there's gap in the maker prices there, too, that's where the gap comes from:

Maybe 21 November 2017 is a better availableSince, otherwise 7 months of data?

[josefansinger]

On 2017-11-21 your reported price is zero. Not what I can see at coinmarketcap. Then 2017-11-21 would be a good availableSince.

FYI, right in the middle on 2018-09-17 there is also a missing price point which is reported in coinmarketcap.

[IvanIvanoff]

I've scheduled a price refill for that time, let's wait some time to see if it's able to get the missing prices. Would take some time as there are thousands of projects and a very low rate limit to cmc.

[IvanIvanoff]

@josefansinger now I actually saw that you're using the daily_avg_price_usd metric instead of price_usd. The price is available, check this out.

The daily_avg_price_usd is something that should be deprecated from the API because of two reasons:

• It is an old metric that was introduced before price_usd and it cannot be easily recalcualted due to internal/dev specifics;
• It is daily, while price_usd is available per 5m and you can aggregate it however you want (as some people prefer average, while other prefer closing price)

PS: There are still some gaps that exist in coinmarketcap but we have not data to fill them, so only the availableSince field change should be addressed

[josefansinger]

@IvanIvanoff Thank you.

I am now calling price_usd, volume_usd, daily_price_low_usd, daily_price_high_usd, daily_price_opening_usd and daily_price_closing_usd.

Any of them deprecated? Are historyPrice() and ohlc() deprecated?

[josefansinger]

If the availableSince field still needs to be addressed, shouldn't we reopen the issue?

[IvanIvanoff]

Let's create a separate issue as this one is gap in MKR prices.

I am now calling price_usd, volume_usd, daily_price_low_usd, daily_price_high_usd, daily_price_opening_usd and daily_price_closing_usd

With price_usd/volume_usd/marketcap_usd + aggregation you can fetch all of the daily_* metrics. For example:

• daily_price_low_usd = price_usd with interval: "1d" and aggregation: MIN
• daily_price_close_usd = price_usd with interval: "1d" and aggregation: LAST
• etc.

high can be achieved with MAX aggregation and open can be achieved with FIRST aggregation.

All of the following are to be deprecated as a better version of them is available:

• daily_avg_marketcap_usd
• daily_avg_price_usd
• daily_closing_marketcap_usd
• daily_closing_price_usd
• daily_high_price_usd
• daily_low_price_usd
• daily_opening_price_usd
• daily_trading_volume_usd

PS: https://github.com/santiment/san-sdk/issues/21 (Discussion only for availableSince)

[josefansinger]

Ah, ok. Opening = FIRST. Closing = LAST.

Then this issue can remain closed.

[IvanIvanoff]

You can explore all available aggregations per metric like this