search

santip / move-panes

Atom package for moving tabs within panes
https://atom.io/packages/move-panes
MIT License
11 stars 4 forks source link

move-panes:move-* generate stacktrace when pane does not exist #13

Open breathe opened 9 years ago

breathe commented 9 years ago

If I currently have one pane and execute any move-pane action -- I get a stacktrace...

[Enter steps to reproduce below:]

  1. Have only one pane open
  2. Execute 'move-pane: move down" operation

Atom Version: 1.0.0 System: Mac OS X 10.10.3 Thrown From: move-panes package, v0.2.0

Stack Trace

Uncaught TypeError: Cannot read property '0' of undefined

At /Users/ncohen/.atom/packages/move-panes/lib/move-panes.coffee:31

TypeError: Cannot read property '0' of undefined
  at Object.module.exports.move (/Users/ncohen/.atom/packages/move-panes/lib/move-panes.coffee:31:6)
  at Object.module.exports.moveRight (/Users/ncohen/.atom/packages/move-panes/lib/move-panes.coffee:11:18)
  at atom-workspace.atom.commands.add.move-panes:move-right (/Users/ncohen/.atom/packages/move-panes/lib/move-panes.coffee:4:70)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:520:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:355:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:180:20)

Commands

     -9:01.7.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -9:01.7.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -8:45.4.0 core:move-left (atom-text-editor.editor.is-focused)
     -8:43.9.0 core:move-right (atom-text-editor.editor.is-focused)
     -8:43.3.0 nuclide-click-to-symbol:activate (atom-text-editor.editor.is-focused)
  2x -8:43.1.0 editor:delete-to-beginning-of-word (atom-text-editor.editor.is-focused)
     -8:41.4.0 nuclide-click-to-symbol:activate (atom-text-editor.editor.is-focused)
     -8:41.2.0 editor:delete-to-beginning-of-word (atom-text-editor.editor.is-focused)
     -8:38 nuclide-click-to-symbol:activate (atom-text-editor.editor.is-focused)
     -8:36.2.0 core:save (atom-text-editor.editor.is-focused)
     -0:58.6.0 core:close (atom-text-editor.editor)
     -0:54.4.0 nuclide-click-to-symbol:activate (atom-text-editor.editor.is-focused)
     -0:54.3.0 core:close (atom-text-editor.editor.is-focused)
     -0:50.8.0 command-palette:toggle (div.settings-view.pane-item)
     -0:32.7.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:32.7.0 core:cancel (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "symbols-view",
      "show-in-system",
      "atom-terminal",
      "metrics",
      "atom-ternjs",
      "tree-view"
    ]
  }
}

Installed Packages

# User
atom-beautify, v0.28.6
atom-ctags, v4.1.4
atomatigit, v1.5.3
autocomplete-clang, v0.7.0
autocomplete-hack, v1.0.1
autocomplete-modules, v0.3.6
autocomplete-python, v0.5.0
linter, v1.0.4
linter-csslint, v0.0.13
linter-eslint, v1.0.8
linter-scss-lint, v1.0.4
move-panes, v0.2.0
nuclide-click-to-symbol, v0.0.21
nuclide-code-format, v0.0.21
nuclide-diff-view, v0.0.21
nuclide-file-tree, v0.0.21
nuclide-file-watcher, v0.0.21
nuclide-flow, v0.0.21
nuclide-hack, v0.0.21
nuclide-hg-repository, v0.0.21
nuclide-installer, v0.0.21
nuclide-language-hack, v0.0.21
nuclide-remote-projects, v0.0.21
nuclide-type-hint, v0.0.21
react, v0.12.0
symbols-tree-view, v0.9.3

# Dev
No dev packages