search

santip / move-panes

Atom package for moving tabs within panes
https://atom.io/packages/move-panes
MIT License
11 stars 4 forks source link

Don't throw stack traces when panes don't exist or nothing to move #16

Closed cabaret closed 1 year ago

cabaret commented 9 years ago

Fixes #13 and #5.

I got a bit tired of seeing those red stack traces when I accidentally tried to move to a non-existing pane, or tried moving when my focus was on an empty pane. This fixes those errors; it doesn't do anything else, however.

I've read the suggestions to open a new pane when moving to a non-existing pane, etc. but I don't have time for it at the moment. I might look into it later, but this fixes my current frustration. Thought I'd send a PR.

colelawrence commented 8 years ago

I threw your changes into https://atom.io/packages/move-panes-cabaret and published just in case someone wants those stacktraces gone.

This also addresses #16 #13 #1

Adding a windows keymap here, maybe helpful for someone ;-)

'atom-workspace atom-text-editor':
  'ctrl-alt-shift-right': 'move-panes-cabaret:move-right'
  'ctrl-alt-shift-left': 'move-panes-cabaret:move-left'
  'ctrl-alt-shift-up': 'move-panes-cabaret:move-up'
  'ctrl-alt-shift-down': 'move-panes-cabaret:move-down'
mbigras commented 8 years ago

thanks @ZombieHippie! Just wanting to send you some encouragement to create something like: move-panes-cabaret:create-and-move-right if the pane doesn't exist yet 😄

colelawrence commented 8 years ago

Great suggestion Max! Unfortunately, I don't have a lot of time to work with Atom, but if you or another friend would like to take a look at this feature, I can help provide resources and guidance if there are questions or problems!

On Tue, 26 Jul 2016, 3:37 PM Max Bigras notifications@github.com wrote:

thanks @ZombieHippie https://github.com/ZombieHippie! Just wanting to send you some encouragement to create something like: move-panes-cabaret:create-and-move-right if the pane doesn't exist yet 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/santip/move-panes/pull/16#issuecomment-235397429, or mute the thread https://github.com/notifications/unsubscribe-auth/ACyjUy_ODAUcDVqp0NNVb7IO-3yAVCMiks5qZnAWgaJpZM4F8giT .

mbigras commented 8 years ago

Thanks @ZombieHippie, I totally understand, time is definitely a factor. I haven't made any atom packages yet, but this could be a good place to start digging around. I'll let you know if I have any questions 😄