search

santiweight / poker-base

BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

cabal file changes #11

Closed tonyday567 closed 2 years ago

tonyday567 commented 2 years ago

Addresses #2

Also added some ghc-options.

santiweight commented 2 years ago

This is fantastic. I realised just now that I don't think I explicitly mentioned something - I personally really need this to compile with ghc-8.6.5, because GHCJS hasn't yet bumped to 8.10.*. If I'm not mistaken, it shouldn't be too hard to keep compatibility - I think we just need to fix one MonadFail import somewhere.

The Contributing is A*. Thanks

I can take this on or you can - let me know.

tonyday567 commented 2 years ago

Thanks, I love this open source stuff. Will leave it with you.

santiweight commented 2 years ago

Is this good to merge? I'm happy to merge for the time being and I can fix cabal locally when I need to.