search

santomegonzalo / react-native-floating-action

Material design action button for React Native
MIT License
489 stars 180 forks source link

Expose testID of Touchable component #121

Open antpuleo2586 opened 4 years ago

antpuleo2586 commented 4 years ago

Can you please expose the testID prop of the Touchable component in FloatingAction.js, so that I can simulate the button press in my tests?

I can open a PR if you'd like.

Cheers!

matheuschagas commented 4 years ago

I created a PR #123 to use testID and accessibilityLabel on FloatActionItem.js

filipearena commented 3 years ago

Is anyone looking at this? I would really appreciate if the testID param was included: I had to do a weird workaround with Detox to be able to tap the FAB :/

CryceTruly commented 3 years ago

Is anyone looking at this? I would really appreciate it if the testID param was included: I had to do a weird workaround with Detox to be able to tap the FAB :/

hey @filipearena, I have a similar problem, I would appreciate knowing what your workaround is?

filipearena commented 3 years ago

@CryceTruly, I basically added the testID by myself on the library component inside my local node_modules so I could at least write the test. Obviously this wouldn't solve the problem given that when running npm install or yarn you would overwrite it. Potentially you could also fork this repo, make the change and then point to your forked Github url (as a temporary fix until they add the param to the library)

bearkfear commented 3 years ago

Test ID PLEASE!