santosderek
commented
3 years ago A few notes:
- On the right column there are metadata options that need to be filed out so I know how to interpret the pull request. Please for any future pull requests update the right hand column so Github can alert me that this needs to be reviewed.
- Metadata includes assigning reviewer (usually me), assignees (usually you), Labels, Projects, and the milestone (for this its the workouts one).
- In the description of any pull request where you have many Github Issues active please do a #
to reference the github issue that this pull request is for. This will also automatically give a note on the GH Issue that it was referenced in this pull request. - For example to reference Github issue number 115 i would type, #115.
- You can also type
Closes #115and once this pull request is closed it will also close that corresponding issue.
Now for the code.
- Which GH Issue is this for? From looking at it, it looks like it is for #115.
- I have requested changes which can be seen above. Very good start though! :smile:
Not sure if I did this right, Let me know what I need to improve on from here