search

santoshimz / pattukunte-pattucheera

https://pattukunte-pattucheera.netlify.app
8 stars 5 forks source link

feature - Add dark mode toggle #97

Closed yashu183 closed 2 years ago

yashu183 commented 2 years ago

Added toggle btn to switch the theme but I feel we need to chnage the green color for light theme

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pattukunte-pattucheera ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 6:34AM (UTC)
netlify[bot] commented 2 years ago

Deploy Preview for pattukunte-pattucheera ready!

Name Link
Latest commit 092011365c49d594ddb18c55e9cf841189ea924b
Latest deploy log https://app.netlify.com/sites/pattukunte-pattucheera/deploys/6316e99d573c1f000851a870
Deploy Preview https://deploy-preview-97--pattukunte-pattucheera.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pavankalyan-codes commented 2 years ago

Added toggle btn to switch the theme but I feel we need to chnage the green color for light theme Thanks for the contribution @yashu183 !! As you said, we need more contrasted color for light theme. green we are using isn't looking good. Try using more darker green. Also, would you be able to movie toggle button below the title. Currently the toggle and the title are overlapping

yashu183 commented 2 years ago

Sure!! Should I grp it with the stats, time travel and info btns?

yashu183 commented 2 years ago

Updated the PR with mentioned changes

pavankalyan-codes commented 2 years ago

Screenshot_2022-09-06-12-12-18-11_40deb401b9ffe8e1df2f1cc5ba480b12.jpg Here the icon is still overlapping with the title. Would you be able to fix that pls. Thanks

pavankalyan-codes commented 2 years ago

Also, not sure what does submit button would be used for. It adds one more extra step for the user.

yashu183 commented 2 years ago

Sure will fix that positioning issue

Regarding the submit btn : As I mentioned in #96 we can get rid of accidental tap. If I want to select the first suggestion in the drop down and I accidently tapped second suggestion its submitting...so unnecessarly users lose their guess so If we have submit btn then they can review it and submit again

I will seperate these two PRs and will raise a new PR for theme toggle

pavankalyan-codes commented 2 years ago

Yeah, separate the PRs. Theme toggle looks fine. Will merge that. We can discuss regarding the submit button UX in a separate PR.

yashu183 commented 2 years ago

Raised another PR for theme toggling