Closed yashu183 closed 2 years ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
pattukunte-pattucheera | ✅ Ready (Inspect) | Visit Preview | Sep 6, 2022 at 6:34AM (UTC) |
Name | Link |
---|---|
Latest commit | 092011365c49d594ddb18c55e9cf841189ea924b |
Latest deploy log | https://app.netlify.com/sites/pattukunte-pattucheera/deploys/6316e99d573c1f000851a870 |
Deploy Preview | https://deploy-preview-97--pattukunte-pattucheera.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Added toggle btn to switch the theme but I feel we need to chnage the green color for light theme Thanks for the contribution @yashu183 !! As you said, we need more contrasted color for light theme. green we are using isn't looking good. Try using more darker green. Also, would you be able to movie toggle button below the title. Currently the toggle and the title are overlapping
Sure!! Should I grp it with the stats, time travel and info btns?
Updated the PR with mentioned changes
Here the icon is still overlapping with the title. Would you be able to fix that pls. Thanks
Also, not sure what does submit button would be used for. It adds one more extra step for the user.
Sure will fix that positioning issue
Regarding the submit btn : As I mentioned in #96 we can get rid of accidental tap. If I want to select the first suggestion in the drop down and I accidently tapped second suggestion its submitting...so unnecessarly users lose their guess so If we have submit btn then they can review it and submit again
I will seperate these two PRs and will raise a new PR for theme toggle
Yeah, separate the PRs. Theme toggle looks fine. Will merge that. We can discuss regarding the submit button UX in a separate PR.
Raised another PR for theme toggling
Added toggle btn to switch the theme but I feel we need to chnage the green color for light theme