Closed mazzma12 closed 5 years ago
This is great thank you. I'll start testing today.
do you have an update on your tests ? It looks like #196 is duplicated, but with more modifications.
You mean #198?
To be clear:
This PR and #198 is to substitute it with chart_studio, which is the minimal step to make the import works. #196 is to use plotly (now offline only) in the long run.
I'm not sure this will work for certain things, like the FigureFactory functions in tools.py here. I'm not sure FigureFactory is even available in chart_studio, AFAIK it's only available via from plotly.tools import FigureFactory
.
It might also be better to move to plotly methods instead of chart_studio for the figure saving in plotlytools.py. The save is here, and could be changed to figure.write_image(). It has the same arguments.
any way to make it work?
@bensdm we should have a fix this week
Done in #202
This is a fix that enables to import
cufflinks
without the error reported at #194 .Not sure how you want to handle the version upgrade for both cufflinks and plotly in the requirements.txt though