search

santropolroulant / smell-test

Monitor router traffic and flag weak TLS configuations
GNU General Public License v3.0
1 stars 2 forks source link

Set non-interactive mode on testssl #15

Closed kousu closed 6 years ago

kousu commented 6 years ago

I left this running for a while on my laptop and just notice it's hung at

[...]
[+] Report generated: ./results/cdnjs.cloudflare.com_20180313-170113.json
[+] Requested "cdn.cyberduck.io." DNS responded "52.84.96.101"
[+] Evaluating cdn.cyberduck.io.

 Start 2018-03-13 17:02:34        -->> 52.84.96.101:443 (52.84.96.101) <<--

 rDNS (52.84.96.101):    --

 52.84.96.101:443 doesn't seem to be a TLS/SSL enabled server
 The results might look ok but they could be nonsense. Really proceed ? ("yes" to continue) -->

Does testssl have a --no-really-i-want-it-noninteractively-please flag?

johnsaigle commented 6 years ago

I've had this issue before also. I'm wondering if we can do this "upstream" so to speak. #4 and #5 also discuss handling for HTTP vs. HTTPS

We should do some other checking to make sure TLS is used on a server, and run testssl if and only if so (instead of finding a flag)

johnsaigle commented 6 years ago

@kousu I believe this is addressed in #16 so I'm going to close this issue. If you find this is not the case please re-open it and we'll troubleshoot 😄