santropolroulant / smell-test

Monitor router traffic and flag weak TLS configuations
GNU General Public License v3.0
1 stars 2 forks source link

Hide testssl output; refactor; add comments #16

Closed johnsaigle closed 6 years ago

johnsaigle commented 6 years ago

Previously I used os.system to call testssl. Using subprocess hides the output and allow us to do nice things like check the exit code and still use the output if we want.

I also made the code more readable and added some comments so that anyone reading this script hopefully won't need to check the testssl docs if they're con(cerned|fused) about the flags