search

santropolroulant / smell-test

Monitor router traffic and flag weak TLS configuations
GNU General Public License v3.0
1 stars 2 forks source link

Write against python2/3 #8

Closed kousu closed 6 years ago

kousu commented 6 years ago

There's a good guide to being cross-compatible here: http://python-future.org/compatible_idioms.html

kousu commented 6 years ago

Oh, I just realized that scapy hasn't been ported to python3. Instead there's a fork called scapy3k.

I don't know how incompatible it is. Maybe it's not a big deal---just

try:
  import scapy3k as scapy
except ImportError:
  import scapy

but maybe it's too much.

if I had my vote, I would write against scapy3k and drop python2 support. python3 is well-established at this point.

johnsaigle commented 6 years ago

So to be clear the preference is to switch to python 3 only and use the scapy3k library?

johnsaigle commented 6 years ago

Closing this because we are now writing for Python3 only.