search

santropolroulant / volunteerdb

MIT License
1 stars 0 forks source link

Show `emergunable` explicitly #23

Closed kousu closed 6 years ago

kousu commented 6 years ago

When you tick off I am unable to provide an emergency contact at this time it does not appear in the volunteer file when saving; rather, nothing shows up.

We should add an explicit line of text, coloured, to point this out.

This is UI tweak to #18.

kousu commented 6 years ago

Huh, that's funny, it looks like this code already exists

https://github.com/santropolroulant/volunteerdb/blob/f1648a5a65163c9424d17ef4d4e418bc338eaf4f/src/Template/Volunteers/view.ctp#L154-L156

but for some reason it's not triggering. From playing around with it a bit, I think there must be an outer if buried somewhere above that's hiding it, and the indentation isn't used right so it's not obvious what's going on.

EDIT: it's this line https://github.com/santropolroulant/volunteerdb/blob/f1648a5a65163c9424d17ef4d4e418bc338eaf4f/src/Template/Volunteers/view.ctp#L117