santry / flickr_tags

An extension for the Radiant CMS that provides tags for embedding Flickr slideshows
http://seansantry.com/projects/flickrtags/
Other
8 stars 6 forks source link

Caching doesn't account for block differences #2

Open jgarber opened 13 years ago

jgarber commented 13 years ago

The cache block should not reuse the cached result when tag bodies differ. What's inside may vary from one use to the next, but currently, the result will be the same because the cache doesn't know better. Failing spec at jgarber@3ab828c

I don't know how to incorporate tag.block into the cache key. The object ID will be different even if the block text is the same, and there's no way to inspect that text by that point.

Maybe we should get rid of caching in light of my performance boost (jgarber@5fa0edb)?