sanusart / react-dropdown-select

Customisable dropdown select for react
https://react-dropdown-select.netlify.app/
MIT License
349 stars 83 forks source link

When dropdown is open, clicking dropdown is not closing #303

Closed musasahinkundakci closed 8 months ago

musasahinkundakci commented 8 months ago

What i want to do is Adding param like closeOnInputClick...

musasahinkundakci commented 8 months ago

I think it would be great bcz, from mobile perspective current behaviour not cool

sanusart commented 8 months ago

Hey. We already have

closeOnSelect
musasahinkundakci commented 8 months ago

Hey. We already have

closeOnSelect

No this is for option selection, On input click, it should be closable... Like mobile apps. The select html input supports it.

Think about it, you have a multi select input and 3 others. small screen and a form.... Closing when u are selecting multiple option is hard. Yeah closeOnSelect good for singleSelect 🤷🏼

sanusart commented 8 months ago

This is not comparable to html select. Clicking outside should close it too. This is how most of selects work.

On Wed, 6 Dec 2023 at 9:41 AM Musa Kundakcı @.***> wrote:

Hey. We already have

closeOnSelect

No this is for option selection, On input click, it should be closable... Like mobile apps. The select html input supports it.

— Reply to this email directly, view it on GitHub https://github.com/sanusart/react-dropdown-select/issues/303#issuecomment-1842264410, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACBLRV2IOFSHYVVQNBUOOLYIAOTTAVCNFSM6AAAAABAIPK5P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGI3DINBRGA . You are receiving this because you commented.Message ID: @.***>

musasahinkundakci commented 8 months ago

Clicking outside + Clicking Input combination those are the examples.

Those component libraries select. components support Clicking outside + Clicking Input; https://mui.com/material-ui/react-select/ https://ant.design/components/select

react-dropdown-select supports;

sanusart commented 8 months ago

Ok. Fair enough. But what about when in search mode?

On Wed, 6 Dec 2023 at 9:55 AM Musa Kundakcı @.***> wrote:

Clicking outside + Clicking Input closes it.

https://mui.com/material-ui/react-select/ https://ant.design/components/select

Not in react-dropdown-select;

  • Supports click on option close
  • Supports close on click out side
  • Doesn't support click on input close...

— Reply to this email directly, view it on GitHub https://github.com/sanusart/react-dropdown-select/issues/303#issuecomment-1842307813, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACBLRSAT5CHUYMHF3RLBW3YIAQH3AVCNFSM6AAAAABAIPK5P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGMYDOOBRGM . You are receiving this because you commented.Message ID: @.***>

musasahinkundakci commented 8 months ago

Search mode of course behaviour will change, closeOnInput click will be disabled. And in the doc it should be dictated. What i think

sanusart commented 8 months ago

Make sense.

On Wed, 6 Dec 2023 at 9:59 AM Musa Kundakcı @.***> wrote:

Search mode of course behaviour will change, closeOnInput click will be disabled. And in the doc it should be dictated. What i think

— Reply to this email directly, view it on GitHub https://github.com/sanusart/react-dropdown-select/issues/303#issuecomment-1842334193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACBLRQSJAUHOMRB6MDMGSLYIAQWDAVCNFSM6AAAAABAIPK5P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGMZTIMJZGM . You are receiving this because you commented.Message ID: @.***>

musasahinkundakci commented 8 months ago

4.11.0 Released. @sanusart Let's close this.