sanusart / react-dropdown-select

Customisable dropdown select for react
https://react-dropdown-select.netlify.app/
MIT License
349 stars 83 forks source link

Feat: 303 added closeOnClickInput support #304

Closed musasahinkundakci closed 8 months ago

musasahinkundakci commented 8 months ago

https://github.com/sanusart/react-dropdown-select/issues/303

If u are searching something closeOnClickInput will be disabled. Gatsby project, README.md updated. Tests are fine.

I didn't make it default true, because current live apps behaviour may change and not good.

codesandbox-ci[bot] commented 8 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f65c98e8dd90594b10cd453e68272c7237f9a27a:

Sandbox Source
react-dropdown-select Configuration
musasahinkundakci commented 8 months ago

Codacy Static Code Analysis @sanusart Is it normal , take too much time ?

sanusart commented 8 months ago

@musasahinkundakci I think it is complaining: https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

musasahinkundakci commented 8 months ago

@musasahinkundakci I think it is complaining: https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

Hmm Actually i was gonna add Common Models in the project... But it s another context.

The props validations, in the Content component none of them were made u know.

But if u want i can do that.

under;

src/models/common.model.js

StateModelProps MethodModelProps PropsModelProps

Also why i said it is another context, When we have this common model props. We should add it to other sub components' props validations...

sanusart commented 8 months ago

@musasahinkundakci I think it is complaining: https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

Hmm Actually i was gonna add Common Models in the project... But it s another context.

The props validations, in the Content component none of them were made u know.

But if u want i can do that.

under;

src/models/common.model.js

StateModelProps MethodModelProps PropsModelProps

Also why i said it is another context, When we have this common model props. We should add it to other sub components' props validations...

Yes, I think models addition are out of scope for this, but lint still need to be fixed imho

musasahinkundakci commented 8 months ago

@musasahinkundakci I think it is complaining: https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

Hmm Actually i was gonna add Common Models in the project... But it s another context. The props validations, in the Content component none of them were made u know. But if u want i can do that. under; src/models/common.model.js StateModelProps MethodModelProps PropsModelProps Also why i said it is another context, When we have this common model props. We should add it to other sub components' props validations...

Yes, I think models addition are out of scope for this, but lint still need to be fixed imho

Cool, i'll fix that

sanusart commented 8 months ago

Amazing, I'll try to release ASAP after the merge as otherwise it looks great.

musasahinkundakci commented 8 months ago

SelectMethodsModel SelectPropsModel SelectStateModel

are added. I didn't want to push deficient commit. At least now we have the models.

Later we can add them to other files. Now other warnings :D Well expected...

musasahinkundakci commented 8 months ago

SelectMethodsModel SelectPropsModel SelectStateModel

are added. I didn't want to push deficient commit. At least now we have the models.

Later we can add them to other files. Now other warnings :D Well expected...

All good

musasahinkundakci commented 8 months ago

SelectMethodsModel SelectPropsModel SelectStateModel are added. I didn't want to push deficient commit. At least now we have the models. Later we can add them to other files. Now other warnings :D Well expected...

All good

I'm gonna cry now :D

musasahinkundakci commented 8 months ago

@sanusart I think there is a problem with code analysis. Please could u check it manually ?

sanusart commented 8 months ago

Maybe it is complaining about == versus === while the prop is boolean?

sanusart commented 8 months ago

I think I gonna merge it and see what with the typing later

sanusart commented 8 months ago

Released v4.11.0.

Thanks so much @musasahinkundakci !

musasahinkundakci commented 8 months ago

Released v4.11.0.

Thanks so much @musasahinkundakci !

Np, I liked ur extendable light-weight library :-) Well done...