sanvi1855544 / sanviapcsp

MIT License
0 stars 3 forks source link

Week 3 - Algorithmic Final #5

Open sanvi1855544 opened 2 years ago

sanvi1855544 commented 2 years ago

Score: 9.5/10 | CB Gennalyn Bongolan

Gennalynb123 commented 2 years ago

CB Gennalyn Bongolan

Score: 9.5/10 Reason: Video exceeds time limit of 2 minutes (video is over 3 minutes). However, all requirements are addressed in the video.

jm1021 commented 2 years ago

Sanvi, your video is great. You really emphasize a lot of the key things you learned and understood. I like that you added comments to things like loops to help you remember workings. Transferring what you learned about function to another person is really good to see. As far as optimization of execution, we can't be sure unless we do analysis. The main purpose of changing to functions is to adopt to Java standard and ensure we are only running what we want out of the file, in our case drivers. There could be many functions in a file we don't want to run. So, I would consider this working according to Python conventions and standards. There is the issue of budget for 2 minutes. Also, there is audio quality issues in your video, specifically in Class / OOP segment. Also, I kind of missed what you did in Crossover GH Pages. As some of these things have happened before it will be a significant deduction. Also, on review ticket your partner did not document everything or compare perform analysis on Akhil video. As person being graded you should be holding them accountable to instructions. 9/10